Patchwork D3037: repo: remove now-unused changectx() method (API)

login
register
mail settings
Submitter phabricator
Date April 3, 2018, 4:14 p.m.
Message ID <differential-rev-PHID-DREV-yyfblz3jhkhyyh6e2mje-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30174/
State Superseded
Headers show

Comments

phabricator - April 3, 2018, 4:14 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3037

AFFECTED FILES
  mercurial/localrepo.py
  mercurial/repository.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel
phabricator - April 3, 2018, 6:21 p.m.
pulkit added a comment.


  I know it's pretty obvious to us that repo.__getitem__ should be used instead but I will like to have that in commit description so when we look back, or someone updates their extensions, some time can be saved.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3037

To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 3, 2018, 8:20 p.m.
martinvonz added a comment.


  In https://phab.mercurial-scm.org/D3037#49157, @pulkit wrote:
  
  > I know it's pretty obvious to us that repo.__getitem__ should be used instead but I will like to have that in commit description so when we look back, or someone updates their extensions, some time can be saved.
  
  
  Makes sense. Done.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3037

To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel

Patch

diff --git a/mercurial/repository.py b/mercurial/repository.py
--- a/mercurial/repository.py
+++ b/mercurial/repository.py
@@ -493,12 +493,6 @@ 
     def file(f):
         """Obtain a filelog for a tracked path."""
 
-    def changectx(changeid):
-        """Obtains a changectx for a revision.
-
-        Identical to __getitem__.
-        """
-
     def setparents(p1, p2):
         """Set the parent nodes of the working directory."""
 
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1073,9 +1073,6 @@ 
             f = f[1:]
         return filelog.filelog(self.svfs, f)
 
-    def changectx(self, changeid):
-        return self[changeid]
-
     def setparents(self, p1, p2=nullid):
         with self.dirstate.parentchange():
             copies = self.dirstate.setparents(p1, p2)