Submitter | Yuya Nishihara |
---|---|
Date | April 3, 2018, 3:40 p.m. |
Message ID | <b37a96bd6c1bcea5d24c.1522770005@mimosa> |
Download | mbox | patch |
Permalink | /patch/30164/ |
State | Accepted |
Headers | show
Return-Path: <mercurial-devel-bounces@mercurial-scm.org> X-Original-To: patchwork@mercurial-scm.org Delivered-To: patchwork@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id E73C02C242; Tue, 3 Apr 2018 11:40:32 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2yUL4k1r-TLR; Tue, 3 Apr 2018 11:40:32 -0400 (EDT) Received: from mercurial-scm.org (localhost [IPv6:::1]) by mercurial-scm.org (Postfix) with ESMTP id 43F7E2C2BD; Tue, 3 Apr 2018 11:40:32 -0400 (EDT) X-Original-To: mercurial-devel@mercurial-scm.org Delivered-To: mercurial-devel@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 4D8DC2C2BD for <mercurial-devel@mercurial-scm.org>; Tue, 3 Apr 2018 11:40:31 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4-Rzh76X9wDT for <mercurial-devel@mercurial-scm.org>; Tue, 3 Apr 2018 11:40:31 -0400 (EDT) Received: from mail-pl0-x22f.google.com (mail-pl0-x22f.google.com [IPv6:2607:f8b0:400e:c01::22f]) by mercurial-scm.org (Postfix) with ESMTPS id 2A4C22C211 for <mercurial-devel@mercurial-scm.org>; Tue, 3 Apr 2018 11:40:29 -0400 (EDT) Received: by mail-pl0-x22f.google.com with SMTP id s24-v6so9337503plq.6 for <mercurial-devel@mercurial-scm.org>; Tue, 03 Apr 2018 08:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:mime-version:content-transfer-encoding:subject:message-id :in-reply-to:references:user-agent:date:from:to; bh=L5cl2Px2HA03aFm2hFRGkdCJrTR8IFYXLuHGPk6t1Yg=; b=NmAWS4Sfr+UQzjyr3LBZusHU/vvTP9x48Hyw36EK4oEkZ/oXRRhKRNNi+5myY7/VGa JZuKZ2sZOCJJR44Zkk17O36Qea3EnqyMamn/SI7YO1MKZcFIxVDxgZTnroPKl1jmw3nR ZecVAHdXEBKs1kUB8EDTgN+S3uQpC/gdy0nMfiOuZjWI8V6tK0kCp+kk4QejnRafXybW aY+cj+U8fMVE/lbZTHtm2J5wM+EBU+D5XDaMLOhoJeG63n9Bqm+5QFBU2NBoIgSSV2dL uEHYoDb6aeiBlLozr5RDqbUYdnmoFzsY/ESyE3ivWBK8eMoTsdHlpMPwrRtT/ZL4HmIC VEUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:mime-version:content-transfer-encoding :subject:message-id:in-reply-to:references:user-agent:date:from:to; bh=L5cl2Px2HA03aFm2hFRGkdCJrTR8IFYXLuHGPk6t1Yg=; b=SzC9hUHx6mvJwHcM/xidiS7IihPyMsVFL/QYzmK7Mw5PngbeUo8+Xy7LXMWFnvrFr1 MeVnHK4IqNzGN6LXfmeB/OPq3khJIlKa94PFinXlxp6d7Qmw5aJZOmskdpseO4ji5U+w Y1Ep8L0k40kYsnmcKU80/CWry8iZFUDbL9LIJu8+WnquEWWsRbDRTA7+pJQFW5iEnVSB v8rBZ5mCgqFzE1VtLBZDSu73zn6Fxz6IYCvhe9apvbMv6xiPrCIuUwYBGN0GRIFoVm/u r6HsuFenisVMWOo9d6Tzww+0AUQ84f/pQ+419HNxmcUHGAFWxtPDZ/I80gcAZu5Wr9LM Lm9A== X-Gm-Message-State: AElRT7H7/PvsHuZimenKK0YXTbql2hSmK4gMyAWkYyR1HIRPcv63rVxn DC0h6tXicJpZvTIKGgNQ/Xc6IUe/ X-Google-Smtp-Source: AIpwx4+f25V0mOocZMe+9nmzZH0NIxtoHQmO8ET3gtmFBTJdycviyi6ywvFSjw+Pb5l3YI5ZttSC1Q== X-Received: by 10.98.15.195 with SMTP id 64mr10811677pfp.63.1522770029042; Tue, 03 Apr 2018 08:40:29 -0700 (PDT) Received: from [127.0.1.1] (p6e42c1b8.tkyea126.ap.so-net.ne.jp. [110.66.193.184]) by smtp.gmail.com with ESMTPSA id j188sm5925811pfc.7.2018.04.03.08.40.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Apr 2018 08:40:28 -0700 (PDT) MIME-Version: 1.0 Subject: [PATCH 3 of 8 V2] templatekw: do not directly call .gen X-Mercurial-Node: b37a96bd6c1bcea5d24c6fc04a92fc6bd407e75e X-Mercurial-Series-Index: 3 X-Mercurial-Series-Total: 8 Message-Id: <b37a96bd6c1bcea5d24c.1522770005@mimosa> X-Mercurial-Series-Id: <164e39f1fc56cebdaa44.1522770003@mimosa> In-Reply-To: <164e39f1fc56cebdaa44.1522770003@mimosa> References: <164e39f1fc56cebdaa44.1522770003@mimosa> User-Agent: Mercurial-patchbomb/4.5.2+1305-fb7140f1d09d Date: Wed, 04 Apr 2018 00:40:05 +0900 From: Yuya Nishihara <yuya@tcha.org> To: mercurial-devel@mercurial-scm.org X-BeenThere: mercurial-devel@mercurial-scm.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <mercurial-devel.mercurial-scm.org> List-Unsubscribe: <https://www.mercurial-scm.org/mailman/options/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=unsubscribe> List-Archive: <http://www.mercurial-scm.org/pipermail/mercurial-devel/> List-Post: <mailto:mercurial-devel@mercurial-scm.org> List-Help: <mailto:mercurial-devel-request@mercurial-scm.org?subject=help> List-Subscribe: <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org> |
Comments
Yuya Nishihara - April 3, 2018, 3:40 p.m.
Patch
diff --git a/mercurial/templatekw.py b/mercurial/templatekw.py --- a/mercurial/templatekw.py +++ b/mercurial/templatekw.py @@ -613,10 +613,7 @@ def showsuccessorssets(context, mapping) # Format the successorssets def render(d): - t = [] - for i in d.gen(): - t.append(i) - return "".join(t) + return templateutil.stringify(context, mapping, d) def gen(data): yield "; ".join(render(d) for d in data)