Patchwork D3006: scmutil: make revpair() return context objects (API)

login
register
mail settings
Submitter phabricator
Date April 1, 2018, 7:11 a.m.
Message ID <differential-rev-PHID-DREV-252keaq3vjvi3hs4bbtg-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30100/
State Superseded
Headers show

Comments

phabricator - April 1, 2018, 7:11 a.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3006

AFFECTED FILES
  mercurial/scmutil.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -447,11 +447,12 @@ 
     return tree and tree[0] in ('range', 'rangepre', 'rangepost', 'rangeall')
 
 def revpairnodes(repo, revs):
-    return revpair(repo, revs)
+    ctx1, ctx2 = revpair(repo, revs)
+    return ctx1.node(), ctx2.node()
 
 def revpair(repo, revs):
     if not revs:
-        return repo.dirstate.p1(), None
+        return repo['.'], repo[None]
 
     l = revrange(repo, revs)
 
@@ -475,9 +476,9 @@ 
 
     # if top-level is range expression, the result must always be a pair
     if first == second and len(revs) == 1 and not _pairspec(revs[0]):
-        return repo.lookup(first), None
+        return repo[first], repo[None]
 
-    return repo.lookup(first), repo.lookup(second)
+    return repo[first], repo[second]
 
 def revrange(repo, specs, localalias=None):
     """Execute 1 to many revsets and return the union.