Patchwork D2992: infinitepush: don't force ipv6 while connecting to mysql server

login
register
mail settings
Submitter phabricator
Date March 31, 2018, 10:23 a.m.
Message ID <differential-rev-PHID-DREV-7hzmxoieef4njlkpxb7n-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30057/
State Superseded
Headers show

Comments

phabricator - March 31, 2018, 10:23 a.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Facebook internally enforces this but looks like we can't force this for pur
  users.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2992

AFFECTED FILES
  hgext/infinitepush/sqlindexapi.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel
phabricator - March 31, 2018, 5:13 p.m.
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  I'm assuming we can drop the argument completely. So I'll do that in flight.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2992

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel

Patch

diff --git a/hgext/infinitepush/sqlindexapi.py b/hgext/infinitepush/sqlindexapi.py
--- a/hgext/infinitepush/sqlindexapi.py
+++ b/hgext/infinitepush/sqlindexapi.py
@@ -61,7 +61,7 @@ 
         while True:
             try:
                 self.sqlconn = mysql.connector.connect(
-                    force_ipv6=True, **self.sqlargs)
+                    force_ipv6=False, **self.sqlargs)
 
                 # Code is copy-pasted from hgsql. Bug fixes need to be
                 # back-ported!