Patchwork D2984: keepalive: implement readinto()

login
register
mail settings
Submitter phabricator
Date March 30, 2018, 9:16 p.m.
Message ID <differential-rev-PHID-DREV-tujesitdc5olpagpmvkq-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30024/
State Superseded
Headers show

Comments

phabricator - March 30, 2018, 9:16 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This is part of the standard I/O interface. It is used by the framing
  protocol. So we need to implement it so frames can be decoded.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2984

AFFECTED FILES
  mercurial/keepalive.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/keepalive.py b/mercurial/keepalive.py
--- a/mercurial/keepalive.py
+++ b/mercurial/keepalive.py
@@ -349,7 +349,7 @@ 
 
 class HTTPResponse(httplib.HTTPResponse):
     # we need to subclass HTTPResponse in order to
-    # 1) add readline() and readlines() methods
+    # 1) add readline(), readlines(), and readinto() methods
     # 2) add close_connection() methods
     # 3) add info() and geturl() methods
 
@@ -522,6 +522,14 @@ 
                 break
         return list
 
+    def readinto(self, dest):
+        res = self.read(len(dest))
+        if not res:
+            return 0
+
+        dest[0:len(res)] = res
+        return len(res)
+
 def safesend(self, str):
     """Send `str' to the server.