Patchwork D2104: infinitepush: drop error handling while pushing to svn server

login
register
mail settings
Submitter phabricator
Date March 30, 2018, 7:52 p.m.
Message ID <18e99923cb7df1541415112931da507f@localhost.localdomain>
Download mbox | patch
Permalink /patch/29998/
State Not Applicable
Headers show

Comments

phabricator - March 30, 2018, 7:52 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3be6f435db4f: infinitepush: drop error handling while pushing to svn server (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2104?vs=5365&id=7419

REVISION DETAIL
  https://phab.mercurial-scm.org/D2104

AFFECTED FILES
  hgext/infinitepush/__init__.py
  tests/test-infinitepush-bundlestore.t

CHANGE DETAILS




To: pulkit, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/tests/test-infinitepush-bundlestore.t b/tests/test-infinitepush-bundlestore.t
--- a/tests/test-infinitepush-bundlestore.t
+++ b/tests/test-infinitepush-bundlestore.t
@@ -369,8 +369,3 @@ 
   |/
   o  initialcommit public
   
-Push to svn server should fail
-  $ hg push svn+ssh://svn.vip.facebook.com/svnroot/tfb/trunk/www -r . --to scratch/serversidebook
-  abort: infinite push does not work with svn repo
-  (did you forget to `hg push default`?)
-  [255]
diff --git a/hgext/infinitepush/__init__.py b/hgext/infinitepush/__init__.py
--- a/hgext/infinitepush/__init__.py
+++ b/hgext/infinitepush/__init__.py
@@ -799,9 +799,6 @@ 
             raise error.Abort(_('default repository not configured!'),
                              hint=_("see 'hg help config.paths'"))
         destpath = path.pushloc or path.loc
-        if destpath.startswith('svn+') and scratchpush:
-            raise error.Abort('infinite push does not work with svn repo',
-                              hint='did you forget to `hg push default`?')
         # Remote scratch bookmarks will be deleted because remotenames doesn't
         # know about them. Let's save it before push and restore after
         remotescratchbookmarks = _readscratchremotebookmarks(ui, repo, destpath)