Patchwork D2929: thirdparty: don't make zope a namespace package

login
register
mail settings
Submitter phabricator
Date March 22, 2018, 4:09 a.m.
Message ID <differential-rev-PHID-DREV-nvp4inzlvho5smlsmwy2-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29767/
State Superseded
Headers show

Comments

phabricator - March 22, 2018, 4:09 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  There are a gazillion zope.* packages in the wild. So zope/__init__.py
  needs to be a namespace package. But in Mercurial, we have 1 zope
  package. And even if we had multiple packages, they'd all be in
  thirdparty/zope/. So we don't need a namespace package.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2929

AFFECTED FILES
  mercurial/thirdparty/zope/__init__.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/thirdparty/zope/__init__.py b/mercurial/thirdparty/zope/__init__.py
--- a/mercurial/thirdparty/zope/__init__.py
+++ b/mercurial/thirdparty/zope/__init__.py
@@ -1,7 +0,0 @@ 
-# this is a namespace package
-try:
-    import pkg_resources
-    pkg_resources.declare_namespace(__name__)
-except ImportError:
-    import pkgutil
-    __path__ = pkgutil.extend_path(__path__, __name__)