From patchwork Wed Mar 21 18:10:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D2909: rebase: remove unused default argument values from conclude[memory]node() From: phabricator X-Patchwork-Id: 29698 Message-Id: To: mercurial-devel@mercurial-scm.org Date: Wed, 21 Mar 2018 18:10:58 +0000 martinvonz created this revision. martinvonz added a reviewer: phillco. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's only "commitmsg" that we don't always pass. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2909 AFFECTED FILES hgext/rebase.py CHANGE DETAILS To: martinvonz, phillco, #hg-reviewers Cc: mercurial-devel diff --git a/hgext/rebase.py b/hgext/rebase.py --- a/hgext/rebase.py +++ b/hgext/rebase.py @@ -1026,9 +1026,8 @@ (max(destancestors), ', '.join("%d" % p for p in sorted(parents)))) -def concludememorynode(repo, rev, p1, p2, wctx=None, - commitmsg=None, editor=None, extrafn=None, - keepbranches=False, date=None): +def concludememorynode(repo, rev, p1, p2, wctx, editor, extrafn, keepbranches, + date, commitmsg=None): '''Commit the memory changes with parents p1 and p2. Reuse commit info from rev but also store useful information in extra. Return node of committed revision.''' @@ -1064,8 +1063,8 @@ wctx.clean() # Might be reused return commitres -def concludenode(repo, rev, p1, p2, commitmsg=None, editor=None, extrafn=None, - keepbranches=False, date=None): +def concludenode(repo, rev, p1, p2, editor, extrafn, keepbranches, date, + commitmsg=None): '''Commit the wd changes with parents p1 and p2. Reuse commit info from rev but also store useful information in extra. Return node of committed revision.'''