D2895: py3: use "%d" % int instead of str(int)

Submitter	phabricator
Date	March 19, 2018, 7:31 a.m.
Message ID	<differential-rev-PHID-DREV-oslqx2k2tgavps6nyx4e-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/29609/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Mon, 19 Mar 2018 07:31:43 +0000 To: mercurial-devel@mercurial-scm.org From: "pulkit (Pulkit Goyal)" <phabricator@mercurial-scm.org> Subject: D2895: py3: use "%d" % int instead of str(int) Message-ID: <differential-rev-PHID-DREV-oslqx2k2tgavps6nyx4e-req@phab.mercurial-scm.org> Thread-Topic: D2895: py3: use "%d" % int instead of str(int) Precedence: bulk Thread-Index: ZWI1YjE0OThmYzkzM2E2MmI5N2VhMzhmYzRm MIME-Version: 1.0 Reply-To: phabricator+D2895+public+2fbc018cd39e30f7@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - March 19, 2018, 7:31 a.m.

pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We need to use bytes internally.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2895

AFFECTED FILES
  mercurial/commands.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -1133,7 +1133,7 @@ 
         fm.startitem()
         fm.write('branch', '%s', tag, label=label)
         rev = ctx.rev()
-        padsize = max(31 - len(str(rev)) - encoding.colwidth(tag), 0)
+        padsize = max(31 - len("%d" % rev) - encoding.colwidth(tag), 0)
         fmt = ' ' * padsize + ' %d:%s'
         fm.condwrite(not ui.quiet, 'rev node', fmt, rev, hexfunc(ctx.node()),
                      label='log.changeset changeset.%s' % ctx.phasestr())

Patchwork D2895: py3: use "%d" % int instead of str(int)

Comments

Patch