Patchwork [5,of,7,V4] revbranchcache: add the necessary bit to send 'rbc' data over bundle2

mail settings
Submitter Boris Feld
Date March 16, 2018, 11:29 a.m.
Message ID <6355ab0513a089c60a59.1521199777@FB>
Download mbox | patch
Permalink /patch/29556/
State Accepted
Headers show


Boris Feld - March 16, 2018, 11:29 a.m.
# HG changeset patch
# User Boris Feld <>
# Date 1516283882 -3600
#      Thu Jan 18 14:58:02 2018 +0100
# Node ID 6355ab0513a089c60a59f76039bea39d07f9e80c
# Parent  d0daa9803d599b7b6fd4f80a773b08a32cc2ccb3
# EXP-Topic wire-rbc
# Available At
#              hg pull -r 6355ab0513a0
revbranchcache: add the necessary bit to send 'rbc' data over bundle2

Getbundle is now capable of sending rev-branch-cache information for the
changesets it bundle. The data sent are mostly nodes so it is quite compact.
The goal of the rev-branch-cache is to speed up branch map computation,
especially when the branchmap gets invalidated so we send data for all
exchanged changesets. In addition, computing the relevant heads to send in
case of partial pulling would be challenging.

The feature is still inactive since the capability is not advertised yet.


diff --git a/mercurial/ b/mercurial/
--- a/mercurial/
+++ b/mercurial/
@@ -1939,6 +1939,28 @@  def _getbundletagsfnodes(bundler, repo, 
     outgoing = _computeoutgoing(repo, heads, common)
     bundle2.addparttagsfnodescache(repo, bundler, outgoing)
+def _getbundlerevbranchcache(bundler, repo, source, bundlecaps=None,
+                             b2caps=None, heads=None, common=None,
+                             **kwargs):
+    """Transfer the rev-branch-cache mapping
+    The payload is a series of data related to each branch
+    1) branch name length
+    2) number of open heads
+    3) number of closed heads
+    4) open heads nodes
+    5) closed heads nodes
+    """
+    # Don't send unless:
+    # - changeset are being exchanged,
+    # - the client supports it.
+    if not (kwargs.get(r'cg', True)) or 'rev-branch-cache' not in b2caps:
+        return
+    outgoing = _computeoutgoing(repo, heads, common)
+    bundle2.addpartrevbranchcache(repo, bundler, outgoing)
 def check_heads(repo, their_heads, context):
     """check if the heads of a repo have been modified