Patchwork D2849: hgweb: also set Content-Type header

login
register
mail settings
Submitter phabricator
Date March 14, 2018, 1:16 a.m.
Message ID <differential-rev-PHID-DREV-4gpapgjpvhvnoldaukte-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29468/
State Superseded
Headers show

Comments

phabricator - March 14, 2018, 1:16 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Our HTTP/WSGI server may convert the Content-Type HTTP request
  header to the CONTENT_TYPE WSGI environment key and not set
  HTTP_CONTENT_TYPE. Other WSGI server implementations
  do this, so I think the behavior is acceptable.
  
  So assuming this HTTP request header could get "lost" by the WSGI
  server, let's restore it on the request object like we do for
  Content-Length.
  
  FWIW, the WSGI server may also *invent* a Content-Type value. The
  default behavior of Python's RFC 822 message class returns a default
  media type if Content-Type isn't defined. This is kind of annoying.
  But RFC 7231 section 3.1.1.5 does say the recipient may assume a media
  type of application/octet-stream. Python's defaults are for
  text/plain (given we're using an RFC 822 parser). But whatever.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2849

AFFECTED FILES
  mercurial/hgweb/request.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/hgweb/request.py b/mercurial/hgweb/request.py
--- a/mercurial/hgweb/request.py
+++ b/mercurial/hgweb/request.py
@@ -325,6 +325,9 @@ 
     if 'CONTENT_LENGTH' in env and 'HTTP_CONTENT_LENGTH' not in env:
         headers['Content-Length'] = env['CONTENT_LENGTH']
 
+    if 'CONTENT_TYPE' in env and 'HTTP_CONTENT_TYPE' not in env:
+        headers['Content-Type'] = env['CONTENT_TYPE']
+
     bodyfh = env['wsgi.input']
     if 'Content-Length' in headers:
         bodyfh = util.cappedreader(bodyfh, int(headers['Content-Length']))