Patchwork D2816: hgweb: remove unused **map argument

login
register
mail settings
Submitter phabricator
Date March 12, 2018, 9:16 p.m.
Message ID <differential-rev-PHID-DREV-vvn4hpyu2dezxsdinzdh-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29326/
State Superseded
Headers show

Comments

phabricator - March 12, 2018, 9:16 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It was unused before the recent code refactoring AFAICT.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2816

AFFECTED FILES
  mercurial/hgweb/hgwebdir_mod.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - March 17, 2018, 3:45 p.m.
yuja added a comment.


  For the record, `**map` was necessary to be an old-style template
  keyword function, which takes all properties passed to `tmpl()`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2816

To: indygreg, #hg-reviewers, durin42
Cc: yuja, mercurial-devel

Patch

diff --git a/mercurial/hgweb/hgwebdir_mod.py b/mercurial/hgweb/hgwebdir_mod.py
--- a/mercurial/hgweb/hgwebdir_mod.py
+++ b/mercurial/hgweb/hgwebdir_mod.py
@@ -148,7 +148,7 @@ 
 
     return archives
 
-def rawindexentries(ui, repos, wsgireq, req, subdir='', **map):
+def rawindexentries(ui, repos, wsgireq, req, subdir=''):
     descend = ui.configbool('web', 'descend')
     collapse = ui.configbool('web', 'collapse')
     seenrepos = set()
@@ -274,9 +274,9 @@ 
         yield row
 
 def indexentries(ui, repos, wsgireq, req, stripecount, sortcolumn='',
-                 descending=False, subdir='', **map):
+                 descending=False, subdir=''):
 
-    rows = rawindexentries(ui, repos, wsgireq, req, subdir=subdir, **map)
+    rows = rawindexentries(ui, repos, wsgireq, req, subdir=subdir)
 
     sortdefault = None, False