Patchwork [Bug,5815] New: ui.debug=True in a config file may prevent extensions from loading

login
register
mail settings
Submitter mercurial-bugs@mercurial-scm.org
Date March 12, 2018, 3:18 a.m.
Message ID <bug-5815-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/29310/
State Not Applicable
Headers show

Comments

mercurial-bugs@mercurial-scm.org - March 12, 2018, 3:18 a.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=5815

            Bug ID: 5815
           Summary: ui.debug=True in a config file may prevent extensions
                    from loading
           Product: Mercurial
           Version: default branch
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: Mercurial
          Assignee: bugzilla@mercurial-scm.org
          Reporter: matt_harbison@yahoo.com
                CC: mercurial-devel@mercurial-scm.org

STR: apply this patch to b434965f984e


With this, the update to tip around line 69 of the test fails, complaining the
'lfs' requirement is missing.  I verified in extensions.loadall() that the
result of `ui.configitems("extensions")` contains no extensions in this case. 
Strangely, --debug and '--config ui.debug=True' specified with the failing
update command *will* allow the extension to load without the patch above (or
if it is set to False in the patch).  Additionally, '--config ui.debug=False'
and --debug on the command line will fail if the patch is applied with True.

I haven't been able to reproduce this with largefiles or in test-lfs.t, which
makes me wonder if there is something else special about this config file.

Patch

diff --git a/tests/test-lfs-test-server.t b/tests/test-lfs-test-server.t
--- a/tests/test-lfs-test-server.t
+++ b/tests/test-lfs-test-server.t
@@ -31,6 +31,8 @@ 
   > [lfs]
   > url=http://foo:bar@$LFS_HOST/
   > track=all()
+  > [ui]
+  > debug = True
   > EOF

   $ hg init repo1