D2804: hgweb: fix a bug due to variable name typo

Submitter	phabricator
Date	March 11, 2018, 5:24 a.m.
Message ID	<differential-rev-PHID-DREV-j2ddw3hubockt53x32pv-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/29295/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Sun, 11 Mar 2018 05:24:56 +0000 To: mercurial-devel@mercurial-scm.org From: "indygreg (Gregory Szorc)" <phabricator@mercurial-scm.org> Subject: D2804: hgweb: fix a bug due to variable name typo Message-ID: <differential-rev-PHID-DREV-j2ddw3hubockt53x32pv-req@phab.mercurial-scm.org> Thread-Topic: D2804: hgweb: fix a bug due to variable name typo Precedence: bulk Thread-Index: NDgzMzljMzgyNWI3YzdiZTk2YmU0YWIxMjk0 MIME-Version: 1.0 Reply-To: phabricator+D2804+public+2225541c108cacdb@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - March 11, 2018, 5:24 a.m.

indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It looks like the "sort" query string parameter was not being
  honored properly.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2804

AFFECTED FILES
  mercurial/hgweb/hgwebdir_mod.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/hgweb/hgwebdir_mod.py b/mercurial/hgweb/hgwebdir_mod.py
--- a/mercurial/hgweb/hgwebdir_mod.py
+++ b/mercurial/hgweb/hgwebdir_mod.py
@@ -481,7 +481,7 @@ 
         sortable = ["name", "description", "contact", "lastchange"]
         sortcolumn, descending = sortdefault
         if 'sort' in wsgireq.req.qsparams:
-            sortcolum = wsgireq.req.qsparams['sort']
+            sortcolumn = wsgireq.req.qsparams['sort']
             descending = sortcolumn.startswith('-')
             if descending:
                 sortcolumn = sortcolumn[1:]

Patchwork D2804: hgweb: fix a bug due to variable name typo

Comments

Patch