Patchwork D2754: phabricator: print deprecation warning only once

login
register
mail settings
Submitter phabricator
Date March 9, 2018, 10:29 p.m.
Message ID <1284d8e0712827e5bb9a5965920967bd@localhost.localdomain>
Download mbox | patch
Permalink /patch/29206/
State Not Applicable
Headers show

Comments

phabricator - March 9, 2018, 10:29 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6490b0915881: phabricator: print deprecation warning only once (authored by joerg.sonnenberger, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2754?vs=6764&id=6794

REVISION DETAIL
  https://phab.mercurial-scm.org/D2754

AFFECTED FILES
  contrib/phabricator.py

CHANGE DETAILS




To: joerg.sonnenberger, #hg-reviewers, durin42
Cc: mercurial-devel

Patch

diff --git a/contrib/phabricator.py b/contrib/phabricator.py
--- a/contrib/phabricator.py
+++ b/contrib/phabricator.py
@@ -99,13 +99,17 @@ 
     process('', params)
     return util.urlreq.urlencode(flatparams)
 
+printed_token_warning = False
+
 def readlegacytoken(repo):
     """Transitional support for old phabricator tokens.
 
     Remove before the 4.6 release.
     """
+    global printed_token_warning
     token = repo.ui.config('phabricator', 'token')
-    if token:
+    if token and not printed_token_warning:
+        printed_token_warning = True
         repo.ui.warn(_('phabricator.token is deprecated - please '
                        'migrate to the phabricator.auth section.\n'))
     return token