Patchwork D2749: hgweb: remove wsgirequest.__iter__

login
register
mail settings
Submitter phabricator
Date March 9, 2018, 2:27 a.m.
Message ID <differential-rev-PHID-DREV-hlm4sypfaxoyanxiq3sv-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29153/
State Superseded
Headers show

Comments

phabricator - March 9, 2018, 2:27 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This was added in https://phab.mercurial-scm.org/rHGd0db3462d568908e3f9789076f006e7502dd2ab2 in 2006. I can't find a justification
  for this method in PEP 0333. The tests all pass without this method.
  So let's nuke it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2749

AFFECTED FILES
  mercurial/hgweb/request.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/hgweb/request.py b/mercurial/hgweb/request.py
--- a/mercurial/hgweb/request.py
+++ b/mercurial/hgweb/request.py
@@ -246,9 +246,6 @@ 
         self.server_write = None
         self.headers = []
 
-    def __iter__(self):
-        return iter([])
-
     def drain(self):
         '''need to read all data from request, httplib is half-duplex'''
         length = int(self.env.get('CONTENT_LENGTH') or 0)