Patchwork D2744: hgweb: handle CONTENT_LENGTH

login
register
mail settings
Submitter phabricator
Date March 9, 2018, 1:06 a.m.
Message ID <differential-rev-PHID-DREV-pczg6gqj4mxsh2vhx46c-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29149/
State Superseded
Headers show

Comments

phabricator - March 9, 2018, 1:06 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  PEP-0333 says CONTENT_LENGTH may be set. I /think/ WSGI servers are
  allowed to invent this key even if the client didn't send it.
  
  We had code in wireprotoserver looking for this key. So let's
  just automagically convert this key to an HTTP request header
  when parsing the request.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2744

AFFECTED FILES
  mercurial/hgweb/request.py
  mercurial/wireprotoserver.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - March 9, 2018, 10:14 p.m.
durin42 accepted this revision.
durin42 added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> wireprotoserver.py:94
>      def forwardpayload(self, fp):
> -        if b'Content-Length' in self._req.headers:
> -            length = int(self._req.headers[b'Content-Length'])
> -        else:
> -            length = int(self._wsgireq.env[r'CONTENT_LENGTH'])
> +        # TODO Content-Length may not always be defined.
> +        length = int(self._req.headers[b'Content-Length'])

For our clients it always will, because we precompute the bundle to a file. It's gross.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2744

To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
phabricator - March 12, 2018, 3:26 p.m.
mharbison72 added inline comments.

INLINE COMMENTS

> request.py:205
> +    # sent. But for all intents and purposes it should be OK to lie about
> +    # this, since a consumer will either either value to determine how many
> +    # bytes are available to read.

typo: "... will either either value..."

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2744

To: indygreg, #hg-reviewers, durin42
Cc: mharbison72, durin42, mercurial-devel

Patch

diff --git a/mercurial/wireprotoserver.py b/mercurial/wireprotoserver.py
--- a/mercurial/wireprotoserver.py
+++ b/mercurial/wireprotoserver.py
@@ -91,10 +91,9 @@ 
         return args
 
     def forwardpayload(self, fp):
-        if b'Content-Length' in self._req.headers:
-            length = int(self._req.headers[b'Content-Length'])
-        else:
-            length = int(self._wsgireq.env[r'CONTENT_LENGTH'])
+        # TODO Content-Length may not always be defined.
+        length = int(self._req.headers[b'Content-Length'])
+
         # If httppostargs is used, we need to read Content-Length
         # minus the amount that was consumed by args.
         length -= int(self._req.headers.get(b'X-HgArgs-Post', 0))
diff --git a/mercurial/hgweb/request.py b/mercurial/hgweb/request.py
--- a/mercurial/hgweb/request.py
+++ b/mercurial/hgweb/request.py
@@ -200,6 +200,13 @@ 
 
     headers = wsgiheaders.Headers(headers)
 
+    # This is kind of a lie because the HTTP header wasn't explicitly
+    # sent. But for all intents and purposes it should be OK to lie about
+    # this, since a consumer will either either value to determine how many
+    # bytes are available to read.
+    if 'CONTENT_LENGTH' in env and 'HTTP_CONTENT_LENGTH' not in env:
+        headers['Content-Length'] = env['CONTENT_LENGTH']
+
     return parsedrequest(url=fullurl, baseurl=baseurl,
                          advertisedurl=advertisedfullurl,
                          advertisedbaseurl=advertisedbaseurl,