Patchwork D2708: rebase: delete obsolete internal "keepopen" option

login
register
mail settings
Submitter phabricator
Date March 7, 2018, 6:23 p.m.
Message ID <differential-rev-PHID-DREV-egu4ycnjlh2hwdc7vn2w-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29095/
State Superseded
Headers show

Comments

phabricator - March 7, 2018, 6:23 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The option was apparently introduced for use by the "pbranch", see
  https://phab.mercurial-scm.org/rHGf2558a8228be7dc016f03f08593c7c010cac1608 (rebase: add option to not commit after a collapsing,
  2010-02-07). However, it doesn't seem like it was ever used by that
  extension (according to `hg grep` in a clone of
  https://bitbucket.org/parren/hg-pbranch/), so let's delete it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2708

AFFECTED FILES
  hgext/rebase.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -174,9 +174,6 @@ 
 
         self.keepf = opts.get('keep', False)
         self.keepbranchesf = opts.get('keepbranches', False)
-        # keepopen is not meant for use on the command line, but by
-        # other extensions
-        self.keepopen = opts.get('keepopen', False)
         self.obsoletenotrebased = {}
         self.obsoletewithoutsuccessorindestination = set()
         self.inmemory = inmemory
@@ -551,7 +548,7 @@ 
         repo, ui, opts = self.repo, self.ui, self.opts
         fm = ui.formatter('rebase', opts)
         fm.startitem()
-        if self.collapsef and not self.keepopen:
+        if self.collapsef:
             p1, p2, _base = defineparents(repo, min(self.state), self.destmap,
                                           self.state, self.skipped,
                                           self.obsoletenotrebased)