Patchwork D2704: archival: fileit should not use atomictemp, causes major performance regression

login
register
mail settings
Submitter phabricator
Date March 7, 2018, 4:26 p.m.
Message ID <261bd310fec7ad0dd7a526a59cc094ab@localhost.localdomain>
Download mbox | patch
Permalink /patch/29090/
State Not Applicable
Headers show

Comments

phabricator - March 7, 2018, 4:26 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa148c67d8b09: archival: fileit should not use atomictemp, causes performance regression (authored by vincent.parrett, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2704?vs=6680&id=6692

REVISION DETAIL
  https://phab.mercurial-scm.org/D2704

AFFECTED FILES
  mercurial/archival.py

CHANGE DETAILS




To: vincent.parrett, #hg-reviewers, durin42
Cc: mercurial-devel

Patch

diff --git a/mercurial/archival.py b/mercurial/archival.py
--- a/mercurial/archival.py
+++ b/mercurial/archival.py
@@ -272,7 +272,7 @@ 
         if islink:
             self.opener.symlink(data, name)
             return
-        f = self.opener(name, "w", atomictemp=True)
+        f = self.opener(name, "w", atomictemp=False)
         f.write(data)
         f.close()
         destfile = os.path.join(self.basedir, name)