Patchwork D2697: util: stop calling os.stat_float_times()

login
register
mail settings
Submitter phabricator
Date March 5, 2018, 9:09 p.m.
Message ID <differential-rev-PHID-DREV-q2qt5htj6sggsyciztqa-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/29048/
State Superseded
Headers show

Comments

phabricator - March 5, 2018, 9:09 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It had Python-wide side effects, and it disappears in 3.7.0.
  
  As of this change, we're mostly working on 3.7.0b2. There are a few
  worrying failures, mostly around regular expressions, but we'll have
  to tackle those separately.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2697

AFFECTED FILES
  mercurial/util.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/util.py b/mercurial/util.py
--- a/mercurial/util.py
+++ b/mercurial/util.py
@@ -176,11 +176,6 @@ 
 
 _notset = object()
 
-# disable Python's problematic floating point timestamps (issue4836)
-# (Python hypocritically says you shouldn't change this behavior in
-# libraries, and sure enough Mercurial is not a library.)
-os.stat_float_times(False)
-
 def safehasattr(thing, attr):
     return getattr(thing, attr, _notset) is not _notset