Patchwork D2662: hghave: do not assign "ex" to a variable (pyflakes)

login
register
mail settings
Submitter phabricator
Date March 4, 2018, 6:24 p.m.
Message ID <differential-rev-PHID-DREV-qsbxtel443xi2rq3gnj4-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/28957/
State Superseded
Headers show

Comments

phabricator - March 4, 2018, 6:24 p.m.
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2662

AFFECTED FILES
  tests/hghave.py

CHANGE DETAILS




To: spectral, #hg-reviewers
Cc: mercurial-devel
phabricator - March 4, 2018, 6:25 p.m.
pulkit added subscribers: durin42, pulkit.
pulkit added a comment.


  @durin42 already did this as https://phab.mercurial-scm.org/D2637.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2662

To: spectral, #hg-reviewers
Cc: pulkit, durin42, mercurial-devel

Patch

diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -715,5 +715,5 @@ 
         from mercurial import policy
         bdiff = policy.importmod('bdiff')
         return bdiff.xdiffblocks('', '') == [(0, 0, 0, 0)]
-    except (ImportError, AttributeError) as ex:
-        return False
+    except (ImportError, AttributeError):
+        return False