Patchwork [3,of,3] test-command-template: glob out detailed "invalid escape" message

login
register
mail settings
Submitter Yuya Nishihara
Date March 2, 2018, 10:25 p.m.
Message ID <5c58b3c471dac34967ae.1520029533@mimosa>
Download mbox | patch
Permalink /patch/28739/
State Accepted
Headers show

Comments

Yuya Nishihara - March 2, 2018, 10:25 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1519946719 18000
#      Thu Mar 01 18:25:19 2018 -0500
# Node ID 5c58b3c471dac34967aeaf32c6a165efbb15bf63
# Parent  2c41855dbd2c20dedb97ac68a1909a9ffa9c0774
test-command-template: glob out detailed "invalid escape" message

Python 3 also reports the position where an invalid escape found.
Augie Fackler - March 3, 2018, 4:42 p.m.
On Fri, Mar 02, 2018 at 05:25:33PM -0500, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1519946719 18000
> #      Thu Mar 01 18:25:19 2018 -0500
> # Node ID 5c58b3c471dac34967aeaf32c6a165efbb15bf63
> # Parent  2c41855dbd2c20dedb97ac68a1909a9ffa9c0774
> test-command-template: glob out detailed "invalid escape" message

queued, thanks

Patch

diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist
--- a/contrib/python3-whitelist
+++ b/contrib/python3-whitelist
@@ -36,6 +36,7 @@  test-children.t
 test-clone-pull-corruption.t
 test-clone-r.t
 test-clone-update-order.t
+test-command-template.t
 test-commit-amend.t
 test-commit-unresolved.t
 test-commit.t
diff --git a/tests/test-command-template.t b/tests/test-command-template.t
--- a/tests/test-command-template.t
+++ b/tests/test-command-template.t
@@ -4438,7 +4438,7 @@  Test broken string escapes:
   hg: parse error: trailing \ in string
   [255]
   $ hg log -T "\\xy" -R a
-  hg: parse error: invalid \x escape
+  hg: parse error: invalid \x escape* (glob)
   [255]
 
 json filter should escape HTML tags so that the output can be embedded in hgweb: