Patchwork py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1

login
register
mail settings
Submitter Kevin Bullock
Date March 2, 2018, 8:38 p.m.
Message ID <71a83808184245c86280.1520023098@ingalls.local>
Download mbox | patch
Permalink /patch/28725/
State Accepted
Headers show

Comments

Kevin Bullock - March 2, 2018, 8:38 p.m.
# HG changeset patch
# User Kevin Bullock <kbullock+mercurial@ringworld.org>
# Date 1520023077 18000
#      Fri Mar 02 15:37:57 2018 -0500
# Node ID 71a83808184245c86280ede647e18e6cc7945594
# Parent  dfcf589a4031211a67bab022e0a1b414f364bc39
py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1
Gregory Szorc - March 2, 2018, 8:45 p.m.
On Fri, Mar 2, 2018 at 3:38 PM, Kevin Bullock <
kbullock+mercurial@ringworld.org> wrote:

> # HG changeset patch
> # User Kevin Bullock <kbullock+mercurial@ringworld.org>
> # Date 1520023077 18000
> #      Fri Mar 02 15:37:57 2018 -0500
> # Node ID 71a83808184245c86280ede647e18e6cc7945594
> # Parent  dfcf589a4031211a67bab022e0a1b414f364bc39
> py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1
>

Queued, thanks.


>
> diff --git a/contrib/python3-ratchet.py b/contrib/python3-ratchet.py
> --- a/contrib/python3-ratchet.py
> +++ b/contrib/python3-ratchet.py
> @@ -80,8 +80,7 @@ def main(argv=()):
>          print('warning: Python 3.6.0 and 3.6.1 have '
>                'a bug which breaks Mercurial')
>          print('(see https://bugs.python.org/issue29714 for details)')
> -        # TODO(augie): uncomment exit when Python 3.6.2 is available
> -        # sys.exit(1)
> +        sys.exit(1)
>
>      rt = subprocess.Popen([opts.python3, 'run-tests.py', '-j',
> str(opts.j),
>                             '--blacklist', opts.working_tests, '--json'])
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/contrib/python3-ratchet.py b/contrib/python3-ratchet.py
--- a/contrib/python3-ratchet.py
+++ b/contrib/python3-ratchet.py
@@ -80,8 +80,7 @@  def main(argv=()):
         print('warning: Python 3.6.0 and 3.6.1 have '
               'a bug which breaks Mercurial')
         print('(see https://bugs.python.org/issue29714 for details)')
-        # TODO(augie): uncomment exit when Python 3.6.2 is available
-        # sys.exit(1)
+        sys.exit(1)
 
     rt = subprocess.Popen([opts.python3, 'run-tests.py', '-j', str(opts.j),
                            '--blacklist', opts.working_tests, '--json'])