Patchwork D2528: error: fix isinstnace check to use bytes instead of str

login
register
mail settings
Submitter phabricator
Date March 2, 2018, 12:32 a.m.
Message ID <e7a5d0f49f3ea0619ce157ff097a96e6@localhost.localdomain>
Download mbox | patch
Permalink /patch/28635/
State Not Applicable
Headers show

Comments

phabricator - March 2, 2018, 12:32 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe28a7a07bb73: error: fix isinstnace check to use bytes instead of str (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2528?vs=6304&id=6309

REVISION DETAIL
  https://phab.mercurial-scm.org/D2528

AFFECTED FILES
  mercurial/error.py

CHANGE DETAILS




To: durin42, #hg-reviewers, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/error.py b/mercurial/error.py
--- a/mercurial/error.py
+++ b/mercurial/error.py
@@ -47,7 +47,7 @@ 
         # this can't be called 'message' because at least some installs of
         # Python 2.6+ complain about the 'message' property being deprecated
         self.lookupmessage = message
-        if isinstance(name, str) and len(name) == 20:
+        if isinstance(name, bytes) and len(name) == 20:
             from .node import short
             name = short(name)
         RevlogError.__init__(self, '%s@%s: %s' % (index, name, message))