Patchwork D2458: py3: use bytes instead of str in isinstance

login
register
mail settings
Submitter phabricator
Date Feb. 26, 2018, 12:32 p.m.
Message ID <differential-rev-PHID-DREV-neeovaogywfuxmbs54wy-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/28391/
State Superseded
Headers show

Comments

phabricator - Feb. 26, 2018, 12:32 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Internally we use bytes everywhere, and str on Python 3 is unicodes, so we need
  to make sure we are doing the right check.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2458

AFFECTED FILES
  mercurial/archival.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/archival.py b/mercurial/archival.py
--- a/mercurial/archival.py
+++ b/mercurial/archival.py
@@ -38,7 +38,7 @@ 
     if prefix:
         prefix = util.normpath(prefix)
     else:
-        if not isinstance(dest, str):
+        if not isinstance(dest, bytes):
             raise ValueError('dest must be string if no prefix')
         prefix = os.path.basename(dest)
         lower = prefix.lower()