Patchwork D2432: patchbomb: resolve revs before evaluating %ld revset

login
register
mail settings
Submitter phabricator
Date Feb. 25, 2018, 1:53 a.m.
Message ID <4648cab0a4d738be3df9c0bdeedee142@localhost.localdomain>
Download mbox | patch
Permalink /patch/28348/
State Not Applicable
Headers show

Comments

phabricator - Feb. 25, 2018, 1:53 a.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG67ec4ad815e6: patchbomb: resolve revs before evaluating %ld revset (authored by indygreg, committed by ).

CHANGED PRIOR TO COMMIT
  https://phab.mercurial-scm.org/D2432?vs=6064&id=6077#toc

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2432?vs=6064&id=6077

REVISION DETAIL
  https://phab.mercurial-scm.org/D2432

AFFECTED FILES
  hgext/patchbomb.py

CHANGE DETAILS




To: indygreg, #hg-reviewers, yuja
Cc: mercurial-devel

Patch

diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
--- a/hgext/patchbomb.py
+++ b/hgext/patchbomb.py
@@ -654,8 +654,9 @@ 
                 else:
                     msg = _('public url %s is missing %s')
                     msg %= (publicurl, missing[0])
+                missingrevs = [ctx.rev() for ctx in missing]
                 revhint = ' '.join('-r %s' % h
-                                  for h in repo.set('heads(%ld)', missing))
+                                   for h in repo.set('heads(%ld)', missingrevs))
                 hint = _("use 'hg push %s %s'") % (publicurl, revhint)
                 raise error.Abort(msg, hint=hint)