Patchwork D2432: patchbomb: resolve revs before evaluating %ld revset

login
register
mail settings
Submitter phabricator
Date Feb. 24, 2018, 7:31 p.m.
Message ID <differential-rev-PHID-DREV-vwce7sbjvlxtylmpgp3h-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/28335/
State Superseded
Headers show

Comments

phabricator - Feb. 24, 2018, 7:31 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Weaning off of basectx.__rev__.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2432

AFFECTED FILES
  hgext/patchbomb.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
--- a/hgext/patchbomb.py
+++ b/hgext/patchbomb.py
@@ -654,8 +654,9 @@ 
                 else:
                     msg = _('public url %s is missing %s')
                     msg %= (publicurl, missing[0])
+                missingrevs = [ctx.rev() for ctx in missing]
                 revhint = ' '.join('-r %s' % h
-                                  for h in repo.set('heads(%ld)', missing))
+                                  for h in repo.set('heads(%ld)', missingrevs))
                 hint = _("use 'hg push %s %s'") % (publicurl, revhint)
                 raise error.Abort(msg, hint=hint)