Patchwork D2401: stack: introduce an option to disable the restriction on ancestor

login
register
mail settings
Submitter phabricator
Date Feb. 23, 2018, 10:37 a.m.
Message ID <differential-rev-PHID-DREV-a2js4vxpzngqilkqimts-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/28273/
State Superseded
Headers show

Comments

phabricator - Feb. 23, 2018, 10:37 a.m.
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The default stack revset restrict on only the ancestors of a revision. Some
  tools might want to display the current stack even if the working directory
  parent is in the middle of the stack.
  
  Add the `stack.restrict-ancestors` option to disable that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2401

AFFECTED FILES
  mercurial/configitems.py
  mercurial/stack.py

CHANGE DETAILS




To: lothiraldan, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/stack.py b/mercurial/stack.py
--- a/mercurial/stack.py
+++ b/mercurial/stack.py
@@ -9,28 +9,34 @@ 
 
 from . import revsetlang, scmutil
 
-baserevspec = "only(%s) and not public()"
+baserevspec = "not public()"
 
 def getstack(repo, rev=None):
     """return a sorted smartrev of the stack containing either rev if it is
     not None or the current working directory parent.
 
-    The stack will always contain all drafts changesets which are ancestors to
-    the revision.
+    The stack will always contain all drafts changesets.
 
     There are several config options to restrict the changesets that will be
     part of the stack:
 
     [stack]
     not-merge = (boolean) # The stack will contains only non-merge changesets
                           # if set to True (default: True)
+    restrict-ancestors = (boolean) # The stack will contain only the
+                                   # ancestors of the revision if set to True
+                                   # (default: True)
     """
     if rev is None:
         rev = '.'
 
-    revspecargs = [revsetlang.formatspec(baserevspec, rev)]
+    revspecargs = [baserevspec]
     revspec = ["%r"]
 
+    if repo.ui.configbool("stack", "restrict-ancestors"):
+        revspecargs.append(revsetlang.formatspec("only(%s)", rev))
+        revspec.append("%r")
+
     if repo.ui.configbool("stack", "not-merge"):
         revspecargs.append("not ::merge()")
         revspec.append("%r")
diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -953,6 +953,9 @@ 
 coreconfigitem('stack', 'not-merge',
     default=True,
 )
+coreconfigitem('stack', 'restrict-ancestors',
+    default=True,
+)
 coreconfigitem('subrepos', 'allowed',
     default=dynamicdefault,  # to make backporting simpler
 )