Patchwork D2386: narrowbundle2: drop legacy getcgkwargs variable

login
register
mail settings
Submitter phabricator
Date Feb. 22, 2018, 4:25 a.m.
Message ID <differential-rev-PHID-DREV-iayilt6znhui5tnkj3ke-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/28235/
State Superseded
Headers show

Comments

phabricator - Feb. 22, 2018, 4:25 a.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I think this was around as part of support for some older hg
  internals. It's not needed any more.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2386

AFFECTED FILES
  hgext/narrow/narrowbundle2.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/narrow/narrowbundle2.py b/hgext/narrow/narrowbundle2.py
--- a/hgext/narrow/narrowbundle2.py
+++ b/hgext/narrow/narrowbundle2.py
@@ -219,13 +219,12 @@ 
                                     bundlecaps=None, b2caps=None, heads=None,
                                     common=None, **kwargs):
     cgversions = b2caps.get('changegroup')
-    getcgkwargs = {}
     if cgversions:  # 3.1 and 3.2 ship with an empty value
         cgversions = [v for v in cgversions
                       if v in changegroup.supportedoutgoingversions(repo)]
         if not cgversions:
             raise ValueError(_('no common changegroup version'))
-        version = getcgkwargs['version'] = max(cgversions)
+        version = max(cgversions)
     else:
         raise ValueError(_("server does not advertise changegroup version,"
                            " can't negotiate support for ellipsis nodes"))