D2372: verify: don't reimplement any()

Submitter	phabricator
Date	Feb. 21, 2018, 6:45 p.m.
Message ID	<differential-rev-PHID-DREV-lxpsb63xrqrhm2qpmi6f-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/28200/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 21 Feb 2018 18:45:16 +0000 To: mercurial-devel@mercurial-scm.org From: "martinvonz (Martin von Zweigbergk)" <phabricator@mercurial-scm.org> Subject: D2372: verify: don't reimplement any() Message-ID: <differential-rev-PHID-DREV-lxpsb63xrqrhm2qpmi6f-req@phab.mercurial-scm.org> Thread-Topic: D2372: verify: don't reimplement any() Precedence: bulk Thread-Index: YmE1ZTNhZGFmMWFjNWVjMDQ1YjE2YThlYjQ2 MIME-Version: 1.0 Reply-To: phabricator+D2372+public+3e05992cdf07d143@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Feb. 21, 2018, 6:45 p.m.

martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2372

AFFECTED FILES
  mercurial/verify.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -456,12 +456,7 @@ 
                     if rp:
                         if lr is not None and ui.verbose:
                             ctx = lrugetctx(lr)
-                            found = False
-                            for pctx in ctx.parents():
-                                if rp[0] in pctx:
-                                    found = True
-                                    break
-                            if not found:
+                            if not any(rp[0] in pctx for pctx in ctx.parents()):
                                 self.warn(_("warning: copy source of '%s' not"
                                             " in parents of %s") % (f, ctx))
                         fl2 = repo.file(rp[0])

Patchwork D2372: verify: don't reimplement any()

Comments

Patch