Patchwork D2278: bundle: updates the help text for hg bundle (issue5744) [bugzilla]

login
register
mail settings
Submitter phabricator
Date Feb. 15, 2018, 1:13 p.m.
Message ID <differential-rev-PHID-DREV-fioprvnyjmc553yxg26d-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27967/
State Superseded
Headers show

Comments

phabricator - Feb. 15, 2018, 1:13 p.m.
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2278

AFFECTED FILES
  mercurial/commands.py

CHANGE DETAILS




To: khanchi97, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 16, 2018, 12:24 p.m.
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> commands.py:1161
> +    Generate a bundle file containing data to be added to the
> +    destination/[DEST] which is probably a repository.
>  

"probably a repository" ?

If `--all` given, the generated bundle isn't intended to be added to the DEST repository.

> commands.py:1167
>      will assume the repository has all the nodes in destination, or
>      default-push/default if no destination is specified.
>  

Here the destination repository is described. I think we can instead refine
this paragraph to clarify what the DEST is.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2278

To: khanchi97, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
phabricator - Feb. 17, 2018, 3:41 a.m.
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> commands.py:1165
>      (or --base null). Otherwise, hg assumes the destination will have
> -    all the nodes you specify with --base parameters. Otherwise, hg
> +    all the nodes you specify with --base parameters, where destination is
> +    the repository you provide through [DEST] option. Otherwise, hg

where the destination repository isn't DEST. :)
`--base` and `--all` are the options incompatible with DEST.

Can you move this to the last sentence?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2278

To: khanchi97, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
phabricator - Feb. 17, 2018, 12:31 p.m.
yuja added a comment.


  Queued, thanks. Dropped `[` `]` from `[DEST]` because `[]` is the notation
  meaning that the `DEST` argument may be omitted.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2278

To: khanchi97, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
phabricator - Feb. 18, 2018, 1:22 p.m.
pulkit added a comment.


  For future bug fixes: we don't append [bugzilla] at the end of commits which fixes bug, we only mention the issue number. We only use bugzilla for bugs/issues so an issue number in the commit message refers to the issue on bugzilla.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2278

To: khanchi97, #hg-reviewers, yuja
Cc: pulkit, yuja, mercurial-devel
phabricator - Feb. 18, 2018, 1:29 p.m.
khanchi97 added a comment.


  Okay, I will take care of that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2278

To: khanchi97, #hg-reviewers, yuja
Cc: pulkit, yuja, mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -1157,7 +1157,8 @@ 
 def bundle(ui, repo, fname, dest=None, **opts):
     """create a bundle file
 
-    Generate a bundle file containing data to be added to a repository.
+    Generate a bundle file containing data to be added to the
+    destination/[DEST] which is probably a repository.
 
     To create a bundle containing all changesets, use -a/--all
     (or --base null). Otherwise, hg assumes the destination will have