Patchwork D2249: py3: whitelist more passing tests

login
register
mail settings
Submitter phabricator
Date Feb. 14, 2018, 12:13 a.m.
Message ID <differential-rev-PHID-DREV-36galv3ofqbtzjgjc5as-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27867/
State Superseded
Headers show

Comments

phabricator - Feb. 14, 2018, 12:13 a.m.
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I had some good success tonight with histedit
  tests. test-histedit-fold.t is now low-hanging fruit: it is only
  failing because the logic for setting environment variables in hook.py
  is slightly busted. Specifically, hook.py line 142 should be making
  sure it puts strings in the env dict, not bytes, to avoid b'' goo in
  environment variables.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2249

AFFECTED FILES
  contrib/python3-whitelist

CHANGE DETAILS




To: durin42, pulkit, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 14, 2018, 5:07 a.m.
indygreg added a comment.


  Can't accept this until https://phab.mercurial-scm.org/D2244 is resolved.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2249

To: durin42, pulkit, #hg-reviewers
Cc: indygreg, mercurial-devel

Patch

diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist
--- a/contrib/python3-whitelist
+++ b/contrib/python3-whitelist
@@ -90,11 +90,15 @@ 
 test-glog-topological.t
 test-gpg.t
 test-hghave.t
+test-histedit-arguments.t
+test-histedit-base.t
 test-histedit-bookmark-motion.t
 test-histedit-commute.t
 test-histedit-drop.t
 test-histedit-edit.t
+test-histedit-fold-non-commute.t
 test-histedit-no-change.t
+test-histedit-non-commute.t
 test-histedit-obsolete.t
 test-histedit-outgoing.t
 test-http-clone-r.t