Patchwork D2237: contrib: ban $RANDOM using check-code

login
register
mail settings
Submitter phabricator
Date Feb. 13, 2018, 11:03 p.m.
Message ID <differential-rev-PHID-DREV-pv2akmgroaqdt5miksag-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27853/
State Superseded
Headers show

Comments

phabricator - Feb. 13, 2018, 11:03 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2237

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -150,6 +150,7 @@ 
     (r'grep.* -[ABC]', "don't use grep's context flags"),
     (r'find.*-printf',
      "don't use 'find -printf', it doesn't exist on BSD find(1)"),
+    (r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
   ],
   # warnings
   [