Submitter | phabricator |
---|---|
Date | Feb. 13, 2018, 10:42 p.m. |
Message ID | <differential-rev-PHID-DREV-mk4kaajftvapxgvw3ql2-req@phab.mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/27848/ |
State | Superseded |
Headers | show |
Comments
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Perhaps we should formalize the manifest interface with an abstract base class... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2232 To: martinvonz, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel
Patch
diff --git a/mercurial/manifest.py b/mercurial/manifest.py --- a/mercurial/manifest.py +++ b/mercurial/manifest.py @@ -755,6 +755,12 @@ size += m.__len__() return size + def __nonzero__(self): + # Faster than "__len() != 0" since it avoids loading sub-manifests + return not self._isempty() + + __bool__ = __nonzero__ + def _isempty(self): self._load() # for consistency; already loaded by all callers return (not self._files and (not self._dirs or