From patchwork Mon Feb 12 20:24:09 2018
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: D2189: narrowrevlog: add a TODO around remotefilelog moving to core
From: phabricator <phabricator@mercurial-scm.org>
X-Patchwork-Id: 27696
Message-Id: <c9b1d573be738061283b2362b9a2cccf@localhost.localdomain>
To: mercurial-devel@mercurial-scm.org
Date: Mon, 12 Feb 2018 20:24:09 +0000

durin42 updated this revision to Diff 5519.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2189?vs=5505&id=5519

REVISION DETAIL
  https://phab.mercurial-scm.org/D2189

AFFECTED FILES
  hgext/narrow/narrowrevlog.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py
--- a/hgext/narrow/narrowrevlog.py
+++ b/hgext/narrow/narrowrevlog.py
@@ -156,6 +156,10 @@
             # rename-checking logic when on remotefilelog. This
             # might be incorrect on other non-revlog-based storage
             # engines, but for now this seems to be fine.
+            #
+            # TODO: when remotefilelog is in core, improve this to
+            # explicitly look for remotefilelog instead of cheating
+            # with a hasattr check.
             if util.safehasattr(self, 'node'):
                 node = self.node(rev)
                 # Because renamed() is overridden above to