From patchwork Mon Feb 12 20:24:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D2186: narrowrevlog: replace AssertionError with ProgrammingError From: phabricator X-Patchwork-Id: 27694 Message-Id: <9cfa793fc8fd0772cc3ed8004dd0ff42@localhost.localdomain> To: mercurial-devel@mercurial-scm.org Date: Mon, 12 Feb 2018 20:24:00 +0000 durin42 updated this revision to Diff 5516. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2186?vs=5502&id=5516 REVISION DETAIL https://phab.mercurial-scm.org/D2186 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS To: durin42, #hg-reviewers Cc: mercurial-devel diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py --- a/hgext/narrow/narrowrevlog.py +++ b/hgext/narrow/narrowrevlog.py @@ -8,6 +8,7 @@ from __future__ import absolute_import from mercurial import ( + error, manifest, revlog, util, @@ -67,8 +68,8 @@ return excludeddir(self._dir, self._node) def write(self, *args): - raise AssertionError('Attempt to write manifest from excluded dir %s' % - self._dir) + raise error.ProgrammingError( + 'attempt to write manifest from excluded dir %s' % self._dir) class excludedmanifestrevlog(manifest.manifestrevlog): """Stand-in for excluded treemanifest revlogs. @@ -84,20 +85,20 @@ self._dir = dir def __len__(self): - raise AssertionError('Attempt to get length of excluded dir %s' % - self._dir) + raise error.ProgrammingError( + 'attempt to get length of excluded dir %s' % self._dir) def rev(self, node): - raise AssertionError('Attempt to get rev from excluded dir %s' % - self._dir) + raise error.ProgrammingError( + 'attempt to get rev from excluded dir %s' % self._dir) def linkrev(self, node): - raise AssertionError('Attempt to get linkrev from excluded dir %s' % - self._dir) + raise error.ProgrammingError( + 'attempt to get linkrev from excluded dir %s' % self._dir) def node(self, rev): - raise AssertionError('Attempt to get node from excluded dir %s' % - self._dir) + raise error.ProgrammingError( + 'attempt to get node from excluded dir %s' % self._dir) def add(self, *args, **kwargs): # We should never write entries in dirlogs outside the narrow clone.