Patchwork D2194: narrowwirepeer: add TODO about how we add wireproto args to unbundle :(

login
register
mail settings
Submitter phabricator
Date Feb. 12, 2018, 8:03 p.m.
Message ID <differential-rev-PHID-DREV-r2emrtjfsirot5sepivs-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27688/
State Superseded
Headers show

Comments

phabricator - Feb. 12, 2018, 8:03 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2194

AFFECTED FILES
  hgext/narrow/narrowwirepeer.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/narrow/narrowwirepeer.py b/hgext/narrow/narrowwirepeer.py
--- a/hgext/narrow/narrowwirepeer.py
+++ b/hgext/narrow/narrowwirepeer.py
@@ -43,6 +43,8 @@ 
     def wirereposetup(ui, peer):
         def wrapped(orig, cmd, *args, **kwargs):
             if cmd == 'unbundle':
+                # TODO: don't blindly add include/exclude wireproto
+                # arguments to unbundle.
                 include, exclude = repo.narrowpats
                 kwargs["includepats"] = ','.join(include)
                 kwargs["excludepats"] = ','.join(exclude)