Patchwork D2189: narrowrevlog: add a TODO around remotefilelog moving to core

login
register
mail settings
Submitter phabricator
Date Feb. 12, 2018, 8:03 p.m.
Message ID <differential-rev-PHID-DREV-ki5b4dpgir54caekhond-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27682/
State Superseded
Headers show

Comments

phabricator - Feb. 12, 2018, 8:03 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We should clean this up considerably when remotefilelog lands, which
  we expect to try and accomplish in the near-ish future.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2189

AFFECTED FILES
  hgext/narrow/narrowrevlog.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py
--- a/hgext/narrow/narrowrevlog.py
+++ b/hgext/narrow/narrowrevlog.py
@@ -156,6 +156,10 @@ 
             # rename-checking logic when on remotefilelog. This
             # might be incorrect on other non-revlog-based storage
             # engines, but for now this seems to be fine.
+            #
+            # TODO: when remotefilelog is in core, improve this to
+            # explicitly look for remotefilelog instead of cheating
+            # with a hasattr check.
             if util.safehasattr(self, 'node'):
                 node = self.node(rev)
                 # Because renamed() is overridden above to