Patchwork D2132: py3: replace file() with open() in test-convert-hg-source.t

login
register
mail settings
Submitter phabricator
Date Feb. 12, 2018, 8:48 a.m.
Message ID <9f418f4f81f89895ebd6478c6488350c@localhost.localdomain>
Download mbox | patch
Permalink /patch/27655/
State Not Applicable
Headers show

Comments

phabricator - Feb. 12, 2018, 8:48 a.m.
pulkit updated this revision to Diff 5481.
pulkit edited the summary of this revision.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2132?vs=5395&id=5481

REVISION DETAIL
  https://phab.mercurial-scm.org/D2132

AFFECTED FILES
  tests/test-convert-hg-source.t

CHANGE DETAILS




To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel

Patch

diff --git a/tests/test-convert-hg-source.t b/tests/test-convert-hg-source.t
--- a/tests/test-convert-hg-source.t
+++ b/tests/test-convert-hg-source.t
@@ -126,9 +126,9 @@ 
   $ cat > rewrite.py <<EOF
   > import sys
   > # Interlace LF and CRLF
-  > lines = [(l.rstrip() + ((i % 2) and '\n' or '\r\n'))
-  >          for i, l in enumerate(file(sys.argv[1]))]
-  > file(sys.argv[1], 'wb').write(''.join(lines))
+  > lines = [(l.rstrip() + ((i % 2) and b'\n' or b'\r\n'))
+  >          for i, l in enumerate(open(sys.argv[1], 'rb'))]
+  > open(sys.argv[1], 'wb').write(b''.join(lines))
   > EOF
   $ $PYTHON rewrite.py new/.hg/shamap
   $ cd orig