Patchwork D2169: py3: explicitly cast bool to bytes

login
register
mail settings
Submitter phabricator
Date Feb. 12, 2018, 3:45 a.m.
Message ID <differential-rev-PHID-DREV-hfd4hwcpv3hpyvjpgptw-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27640/
State Superseded
Headers show

Comments

phabricator - Feb. 12, 2018, 3:45 a.m.
indygreg created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Yes, the file format actually looks for literal `True`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2169

AFFECTED FILES
  hgext/histedit.py

CHANGE DETAILS




To: indygreg, durin42, #hg-reviewers
Cc: mercurial-devel
Augie Fackler - Feb. 13, 2018, 3:09 a.m.
This appears to break histedit tests for me somehow, which is curious because I swear they passed once. I'll drop it for now and try to come back to it.

> On Feb 12, 2018, at 21:48, indygreg (Gregory Szorc) <phabricator@mercurial-scm.org> wrote:
> 
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rHGd78a51982262: py3: explicitly cast bool to bytes (authored by indygreg, committed by ).
> 
> REPOSITORY
>  rHG Mercurial
> 
> CHANGES SINCE LAST UPDATE
>  https://phab.mercurial-scm.org/D2169?vs=5470&id=5592
> 
> REVISION DETAIL
>  https://phab.mercurial-scm.org/D2169
> 
> AFFECTED FILES
>  hgext/histedit.py
> 
> CHANGE DETAILS
> 
> diff --git a/hgext/histedit.py b/hgext/histedit.py
> --- a/hgext/histedit.py
> +++ b/hgext/histedit.py
> @@ -344,7 +344,7 @@
>         fp.write('v1\n')
>         fp.write('%s\n' % node.hex(self.parentctxnode))
>         fp.write('%s\n' % node.hex(self.topmost))
> -        fp.write('%s\n' % self.keep)
> +        fp.write('%s\n' % 'True' if self.keep else 'False')
>         fp.write('%d\n' % len(self.actions))
>         for action in self.actions:
>             fp.write('%s\n' % action.tostate())
> 
> 
> 
> To: indygreg, durin42, #hg-reviewers, pulkit
> Cc: mercurial-devel

Patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -344,7 +344,7 @@ 
         fp.write('v1\n')
         fp.write('%s\n' % node.hex(self.parentctxnode))
         fp.write('%s\n' % node.hex(self.topmost))
-        fp.write('%s\n' % self.keep)
+        fp.write('%s\n' % 'True' if self.keep else 'False')
         fp.write('%d\n' % len(self.actions))
         for action in self.actions:
             fp.write('%s\n' % action.tostate())