Patchwork D2122: py3: replace file() with open() in test-mactext.t

login
register
mail settings
Submitter phabricator
Date Feb. 11, 2018, 12:41 p.m.
Message ID <differential-rev-PHID-DREV-2p57fleetuqecdr5sbzt-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27537/
State Superseded
Headers show

Comments

phabricator - Feb. 11, 2018, 12:41 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  file() is not present in Python 3.
  This patch also adds a b'' prefix to make sure we write bytes in Python 3.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2122

AFFECTED FILES
  tests/test-mactext.t

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-mactext.t b/tests/test-mactext.t
--- a/tests/test-mactext.t
+++ b/tests/test-mactext.t
@@ -3,9 +3,9 @@ 
   > import sys
   > 
   > for path in sys.argv[1:]:
-  >     data = file(path, 'rb').read()
-  >     data = data.replace('\n', '\r')
-  >     file(path, 'wb').write(data)
+  >     data = open(path, 'rb').read()
+  >     data = data.replace(b'\n', b'\r')
+  >     open(path, 'wb').write(data)
   > EOF
   $ cat > print.py <<EOF
   > import sys