Patchwork D2112: py3: replace file() with open() in test-convert-p4-filetypes.t

login
register
mail settings
Submitter phabricator
Date Feb. 11, 2018, 12:39 p.m.
Message ID <differential-rev-PHID-DREV-ssdh2c4k5j77rzdshz5f-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27527/
State Superseded
Headers show

Comments

phabricator - Feb. 11, 2018, 12:39 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  file() is not present in Python 3. While I was here, I added b'' prefix to make
  sure we write things correctly in Python 3.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2112

AFFECTED FILES
  tests/test-convert-p4-filetypes.t

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-convert-p4-filetypes.t b/tests/test-convert-p4-filetypes.t
--- a/tests/test-convert-p4-filetypes.t
+++ b/tests/test-convert-p4-filetypes.t
@@ -52,7 +52,7 @@ 
   >          p4 add -t $T file_$T2
   >          ;;
   >       binary*)
-  >          $PYTHON -c "file('file_$T2', 'wb').write('this is $T')"
+  >          $PYTHON -c "open('file_$T2', 'wb').write(b'this is $T')"
   >          p4 add -t $T file_$T2
   >          ;;
   >       *)