Patchwork D2105: infinitepush: drop hack related to --to, --create flags of remotenames-ext

login
register
mail settings
Submitter phabricator
Date Feb. 9, 2018, 11:46 a.m.
Message ID <differential-rev-PHID-DREV-gb7zucdsiup5vssdidha-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27507/
State Superseded
Headers show

Comments

phabricator - Feb. 9, 2018, 11:46 a.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The remotenames extension has --to, --create. --allow-anon flags which won't be
  ported to core. This patch drops the hack which fixes the interaction with
  remotenames-ext during push.
  
  In upcoming patches, --to and --create extensions will be removed from
  infinitepush also.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2105

AFFECTED FILES
  hgext/infinitepush/__init__.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/infinitepush/__init__.py b/hgext/infinitepush/__init__.py
--- a/hgext/infinitepush/__init__.py
+++ b/hgext/infinitepush/__init__.py
@@ -771,16 +771,6 @@ 
     with ui.configoverride(overrides, 'infinitepush'):
         scratchpush = opts.get('bundle_store')
         if _scratchbranchmatcher(bookmark):
-            # Hack to fix interaction with remotenames. Remotenames push
-            # '--to' bookmark to the server but we don't want to push scratch
-            # bookmark to the server. Let's delete '--to' and '--create' and
-            # also set allow_anon to True (because if --to is not set
-            # remotenames will think that we are pushing anonymoush head)
-            if 'to' in opts:
-                del opts['to']
-            if 'create' in opts:
-                del opts['create']
-            opts['allow_anon'] = True
             scratchpush = True
             # bundle2 can be sent back after push (for example, bundle2
             # containing `pushkey` part to update bookmarks)