Patchwork D2095: updates the help text for hg clone -r (issue5654) on bugzilla

login
register
mail settings
Submitter phabricator
Date Feb. 8, 2018, 6:05 p.m.
Message ID <differential-rev-PHID-DREV-a2pngeo5ruplxp5ttqvd-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27495/
State Superseded
Headers show

Comments

phabricator - Feb. 8, 2018, 6:05 p.m.
sangeet259 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

AFFECTED FILES
  mercurial/commands.py

CHANGE DETAILS




To: sangeet259, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 9, 2018, 2:43 p.m.
dlax added a comment.


  As mentioned in the issue, there's already an explanation paragraph help:
  
    To pull only a subset of changesets, specify one or more revisions
    identifiers with -r/--rev or branches with -b/--branch. The resulting
    clone will contain only the specified changesets and their ancestors.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers
Cc: dlax, mercurial-devel
phabricator - Feb. 9, 2018, 9:27 p.m.
sangeet259 added a comment.


  @dlax Yes, but the short summary didn't say what it does! It just says "include the specified changeset".

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers
Cc: dlax, mercurial-devel
phabricator - Feb. 11, 2018, 6:29 p.m.
dlax added a comment.


  sangeet259 (Sangeet Kumar Mishra) wrote:
  
  > @dlax https://phab.mercurial-scm.org/p/dlax/ Yes, but the short 
  >  summary didn't say what it does! It just says "include the specified 
  >  changeset".
  
  I agree it's not super-clear. Perhaps we could say "clone only specified 
  changeset" for -r (help for -b looks ok to me).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers
Cc: dlax, mercurial-devel
phabricator - Feb. 11, 2018, 8:15 p.m.
joerg.sonnenberger added a comment.


  There was a longish discussion on IRC about this. The problem is that the flags by themselves do not document the interaction of -r and -b or multiple instances of either at all. The change was a compromise trying to address that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers
Cc: joerg.sonnenberger, dlax, mercurial-devel
phabricator - Feb. 13, 2018, 4:03 p.m.
sangeet259 added a comment.


  In https://phab.mercurial-scm.org/D2095#35494, @joerg.sonnenberger wrote:
  
  > There was a longish discussion on IRC about this. The problem is that the flags by themselves do not document the interaction of -r and -b or multiple instances of either at all. The change was a compromise trying to address that.
  
  
  Yeah, I had a long discussion regarding this on IRC, this is finally what all agreed upon.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers
Cc: joerg.sonnenberger, dlax, mercurial-devel
phabricator - Feb. 15, 2018, 1:37 a.m.
durin42 accepted this revision as: durin42.
durin42 added a comment.


  I can live with this as a strict improvement over what we've got. Anyone object or want to agree with me?
  
  (I'm happy to fix the inevitable test changes in flight)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers, durin42
Cc: durin42, joerg.sonnenberger, dlax, mercurial-devel
phabricator - Feb. 18, 2018, 1:24 p.m.
pulkit added a comment.


  For future bug fixes: we don't append [bugzilla] at the end of commits which fixes bug, we only mention the issue number. We use bugzilla only for bugs/issues, so an issue number in the commit message refers to the issue on bugzilla.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers, durin42
Cc: pulkit, durin42, joerg.sonnenberger, dlax, mercurial-devel
phabricator - Feb. 18, 2018, 2:21 p.m.
sangeet259 added a comment.


  Oh! Thanks for letting me know!
  I will keep that in mind.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2095

To: sangeet259, #hg-reviewers, durin42
Cc: pulkit, durin42, joerg.sonnenberger, dlax, mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -1320,7 +1320,8 @@ 
                                'directory (only a repository)')),
     ('u', 'updaterev', '', _('revision, tag, or branch to check out'),
         _('REV')),
-    ('r', 'rev', [], _('include the specified changeset'), _('REV')),
+    ('r', 'rev', [], _('clone the repo starting from the first changeset \
+        to the specified changeset'), _('REV')),
     ('b', 'branch', [], _('clone only the specified branch'), _('BRANCH')),
     ('', 'pull', None, _('use pull protocol to copy metadata')),
     ('', 'uncompressed', None,