Patchwork D2092: wireprotoserver: add version to SSH protocol names (API)

login
register
mail settings
Submitter phabricator
Date Feb. 8, 2018, 5:21 a.m.
Message ID <differential-rev-PHID-DREV-iiywtsvontrsgtethhh3-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27486/
State Superseded
Headers show

Comments

phabricator - Feb. 8, 2018, 5:21 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We recently introduced version 2 of the SSH protocol. Like we
  did for the peer, we will need to differentiate version 1 and 2
  of the server. So, we add version components to the advertised
  name of the protocol handler.
  
  Nothing in core looks for the old value. But an extension may.
  
  .. api::
  
    SSH protocol handler now advertises its name internally as
    "ssh-v1" instead of "ssh."

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2092

AFFECTED FILES
  mercurial/wireprotoserver.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/wireprotoserver.py b/mercurial/wireprotoserver.py
--- a/mercurial/wireprotoserver.py
+++ b/mercurial/wireprotoserver.py
@@ -367,7 +367,7 @@ 
 
     @property
     def name(self):
-        return 'ssh'
+        return SSHV1
 
     def getargs(self, args):
         data = {}