Patchwork D2086: wireproto: remove unused proto argument from supportedcompengines (API)

login
register
mail settings
Submitter phabricator
Date Feb. 8, 2018, 4:32 a.m.
Message ID <9a0b1529b5bf70c752c7bb7917452d8a@localhost.localdomain>
Download mbox | patch
Permalink /patch/27473/
State Not Applicable
Headers show

Comments

phabricator - Feb. 8, 2018, 4:32 a.m.
indygreg updated this revision to Diff 5338.
indygreg retitled this revision from "wireproto: remove unused proto argument from supportedcompengines" to "wireproto: remove unused proto argument from supportedcompengines (API)".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2086?vs=5320&id=5338

REVISION DETAIL
  https://phab.mercurial-scm.org/D2086

AFFECTED FILES
  mercurial/wireproto.py
  mercurial/wireprotoserver.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/wireprotoserver.py b/mercurial/wireprotoserver.py
--- a/mercurial/wireprotoserver.py
+++ b/mercurial/wireprotoserver.py
@@ -192,7 +192,7 @@ 
                     break
 
             # Now find an agreed upon compression format.
-            for engine in wireproto.supportedcompengines(self._ui, self,
+            for engine in wireproto.supportedcompengines(self._ui,
                                                          util.SERVERROLE):
                 if engine.wireprotosupport().name in compformats:
                     opts = {}
diff --git a/mercurial/wireproto.py b/mercurial/wireproto.py
--- a/mercurial/wireproto.py
+++ b/mercurial/wireproto.py
@@ -587,7 +587,7 @@ 
 
     return ui.configbool('server', 'bundle1')
 
-def supportedcompengines(ui, proto, role):
+def supportedcompengines(ui, role):
     """Obtain the list of supported compression engines for a request."""
     assert role in (util.CLIENTROLE, util.SERVERROLE)
 
@@ -824,7 +824,7 @@ 
         # FUTURE advertise minrx and mintx after consulting config option
         caps.append('httpmediatype=0.1rx,0.1tx,0.2tx')
 
-        compengines = supportedcompengines(repo.ui, proto, util.SERVERROLE)
+        compengines = supportedcompengines(repo.ui, util.SERVERROLE)
         if compengines:
             comptypes = ','.join(urlreq.quote(e.wireprotosupport().name)
                                  for e in compengines)