Patchwork D2045: check-config: specify the mode 'rb' to open the file

login
register
mail settings
Submitter phabricator
Date Feb. 5, 2018, 2:27 p.m.
Message ID <33f59e794f5d6b591ed7015e0fdf333b@localhost.localdomain>
Download mbox | patch
Permalink /patch/27319/
State Not Applicable
Headers show

Comments

phabricator - Feb. 5, 2018, 2:27 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG143d7b27b09c: check-config: specify the mode &#039;rb&#039; to open the file (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2045?vs=5203&id=5216

REVISION DETAIL
  https://phab.mercurial-scm.org/D2045

AFFECTED FILES
  contrib/check-config.py

CHANGE DETAILS




To: pulkit, #hg-reviewers, yuja
Cc: mercurial-devel

Patch

diff --git a/contrib/check-config.py b/contrib/check-config.py
--- a/contrib/check-config.py
+++ b/contrib/check-config.py
@@ -49,7 +49,7 @@ 
         confsect = ''
         carryover = ''
         linenum = 0
-        for l in open(f):
+        for l in open(f, 'rb'):
             linenum += 1
 
             # check topic-like bits