Patchwork makefile: remove Ubuntu Yakkety and Zesty docker targets

login
register
mail settings
Submitter Anton Shestakov
Date Feb. 5, 2018, 10:48 a.m.
Message ID <d5509e242b927dbee808.1517827680@neuro>
Download mbox | patch
Permalink /patch/27307/
State Accepted
Headers show

Comments

Anton Shestakov - Feb. 5, 2018, 10:48 a.m.
# HG changeset patch
# User Anton Shestakov <av6@dwimlabs.net>
# Date 1517827181 -28800
#      Mon Feb 05 18:39:41 2018 +0800
# Node ID d5509e242b927dbee808e4d62a7f10b3a5c406cf
# Parent  ed3a7300b7b5a427bdcffefd0c80aab65824bf4b
makefile: remove Ubuntu Yakkety and Zesty docker targets

Yakkety (16.10) was supported until 2017-07-20 and Zesty (17.04) was supported
until 2018-01-13.
Yuya Nishihara - Feb. 5, 2018, 1:23 p.m.
On Mon, 05 Feb 2018 18:48:00 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <av6@dwimlabs.net>
> # Date 1517827181 -28800
> #      Mon Feb 05 18:39:41 2018 +0800
> # Node ID d5509e242b927dbee808e4d62a7f10b3a5c406cf
> # Parent  ed3a7300b7b5a427bdcffefd0c80aab65824bf4b
> makefile: remove Ubuntu Yakkety and Zesty docker targets

Queued, thanks.
Gregory Szorc - Feb. 5, 2018, 5:22 p.m.
On Mon, Feb 5, 2018 at 5:23 AM, Yuya Nishihara <yuya@tcha.org> wrote:

> On Mon, 05 Feb 2018 18:48:00 +0800, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <av6@dwimlabs.net>
> > # Date 1517827181 -28800
> > #      Mon Feb 05 18:39:41 2018 +0800
> > # Node ID d5509e242b927dbee808e4d62a7f10b3a5c406cf
> > # Parent  ed3a7300b7b5a427bdcffefd0c80aab65824bf4b
> > makefile: remove Ubuntu Yakkety and Zesty docker targets
>
> Queued, thanks.
>

In the past, I've had to restore support for some old distros in order to
build modern Mercurial packages for some older distros that still had
limited use in the wild. So there is value to keeping these targets around
even if the distro is no longer supported upstream. It's only a minor
inconvenience for me. I just thought I'd raise the concern in case it
influences our decision making on patches like this.
Yuya Nishihara - Feb. 6, 2018, 2:44 p.m.
On Mon, 5 Feb 2018 09:22:02 -0800, Gregory Szorc wrote:
> On Mon, Feb 5, 2018 at 5:23 AM, Yuya Nishihara <yuya@tcha.org> wrote:
> 
> > On Mon, 05 Feb 2018 18:48:00 +0800, Anton Shestakov wrote:
> > > # HG changeset patch
> > > # User Anton Shestakov <av6@dwimlabs.net>
> > > # Date 1517827181 -28800
> > > #      Mon Feb 05 18:39:41 2018 +0800
> > > # Node ID d5509e242b927dbee808e4d62a7f10b3a5c406cf
> > > # Parent  ed3a7300b7b5a427bdcffefd0c80aab65824bf4b
> > > makefile: remove Ubuntu Yakkety and Zesty docker targets
> >
> > Queued, thanks.
> >
> 
> In the past, I've had to restore support for some old distros in order to
> build modern Mercurial packages for some older distros that still had
> limited use in the wild. So there is value to keeping these targets around
> even if the distro is no longer supported upstream. It's only a minor
> inconvenience for me. I just thought I'd raise the concern in case it
> influences our decision making on patches like this.

I have no preference. It's just a make rule kicking one command. It could
even be "make docker-ubuntu CODENAME=yakkety" so we don't have to update
our Makefile per Ubuntu release.

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -234,18 +234,6 @@  docker-ubuntu-xenial: contrib/docker/ubu
 docker-ubuntu-xenial-ppa: contrib/docker/ubuntu-xenial
 	contrib/dockerdeb ubuntu xenial --source-only
 
-docker-ubuntu-yakkety: contrib/docker/ubuntu-yakkety
-	contrib/dockerdeb ubuntu yakkety
-
-docker-ubuntu-yakkety-ppa: contrib/docker/ubuntu-yakkety
-	contrib/dockerdeb ubuntu yakkety --source-only
-
-docker-ubuntu-zesty: contrib/docker/ubuntu-zesty
-	contrib/dockerdeb ubuntu zesty
-
-docker-ubuntu-zesty-ppa: contrib/docker/ubuntu-zesty
-	contrib/dockerdeb ubuntu zesty --source-only
-
 docker-ubuntu-artful: contrib/docker/ubuntu-artful
 	contrib/dockerdeb ubuntu artful
 
@@ -318,8 +306,6 @@  linux-wheels-i686:
 	osx deb ppa docker-debian-jessie docker-debian-stretch \
 	docker-ubuntu-trusty docker-ubuntu-trusty-ppa \
 	docker-ubuntu-xenial docker-ubuntu-xenial-ppa \
-	docker-ubuntu-yakkety docker-ubuntu-yakkety-ppa \
-	docker-ubuntu-zesty docker-ubuntu-zesty-ppa \
 	docker-ubuntu-artful docker-ubuntu-artful-ppa \
 	fedora20 docker-fedora20 fedora21 docker-fedora21 \
 	centos5 docker-centos5 centos6 docker-centos6 centos7 docker-centos7 \