Patchwork D2045: check-config: specify the mode 'rb' to open the file

login
register
mail settings
Submitter phabricator
Date Feb. 5, 2018, 8:23 a.m.
Message ID <differential-rev-PHID-DREV-bcwhbubmtyewfyhjisvj-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27304/
State Superseded
Headers show

Comments

phabricator - Feb. 5, 2018, 8:23 a.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2045

AFFECTED FILES
  contrib/check-config.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/check-config.py b/contrib/check-config.py
--- a/contrib/check-config.py
+++ b/contrib/check-config.py
@@ -49,7 +49,7 @@ 
         confsect = ''
         carryover = ''
         linenum = 0
-        for l in open(f):
+        for l in open(f, 'rb'):
             linenum += 1
 
             # check topic-like bits