Patchwork [3,of,3] logcmdutil: mark changesetprinter.showpatch() as private

login
register
mail settings
Submitter Yuya Nishihara
Date Feb. 4, 2018, 11:18 a.m.
Message ID <4d7182357056c2672716.1517743102@mimosa>
Download mbox | patch
Permalink /patch/27281/
State Accepted
Headers show

Comments

Yuya Nishihara - Feb. 4, 2018, 11:18 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1516510856 -32400
#      Sun Jan 21 14:00:56 2018 +0900
# Node ID 4d7182357056c2672716d7caf849231d7b25691a
# Parent  f1a8a49af81a97618a4b1eb7e78c7372db776cdc
logcmdutil: mark changesetprinter.showpatch() as private
Augie Fackler - Feb. 7, 2018, 11:34 a.m.
> On Feb 4, 2018, at 12:18, Yuya Nishihara <yuya@tcha.org> wrote:
> 
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1516510856 -32400
> #      Sun Jan 21 14:00:56 2018 +0900
> # Node ID 4d7182357056c2672716d7caf849231d7b25691a
> # Parent  f1a8a49af81a97618a4b1eb7e78c7372db776cdc
> logcmdutil: mark changesetprinter.showpatch() as private

queued, thanks

Patch

diff --git a/mercurial/logcmdutil.py b/mercurial/logcmdutil.py
--- a/mercurial/logcmdutil.py
+++ b/mercurial/logcmdutil.py
@@ -251,7 +251,7 @@  class changesetprinter(object):
                               label='log.summary')
         self.ui.write("\n")
 
-        self.showpatch(ctx, matchfn, hunksfilterfn=hunksfilterfn)
+        self._showpatch(ctx, matchfn, hunksfilterfn=hunksfilterfn)
 
     def _showobsfate(self, ctx):
         obsfate = templatekw.showobsfate(repo=self.repo, ctx=ctx, ui=self.ui)
@@ -265,7 +265,7 @@  class changesetprinter(object):
         '''empty method used by extension as a hook point
         '''
 
-    def showpatch(self, ctx, matchfn, hunksfilterfn=None):
+    def _showpatch(self, ctx, matchfn, hunksfilterfn=None):
         if not matchfn:
             matchfn = self.matchfn
         if matchfn:
@@ -469,7 +469,7 @@  class changesettemplater(changesetprinte
         # write changeset metadata, then patch if requested
         key = self._parts[self._tref]
         self.ui.write(templater.stringify(self.t(key, **props)))
-        self.showpatch(ctx, matchfn, hunksfilterfn=hunksfilterfn)
+        self._showpatch(ctx, matchfn, hunksfilterfn=hunksfilterfn)
 
         if self._parts['footer']:
             if not self.footer: